[wip] feature: also use .GitInfo.lastmod when available

ryanburnette / eon

This is eon, it's a Hugo theme and custom Bulma implementation used for building websites.

ISC License

3 stars 1 forks source link

[wip] feature: also use .GitInfo.lastmod when available #21

Open coolaj86 opened 3 years ago

coolaj86 commented 3 years ago

Preview at: https://github.com/coolaj86/eon/tree/patch-2

Precedence:

.Page.lastmod (if different)
.GitInfo.lastmod (always different)
nothing

I'm thinking about switching this around so that .GitInfo.lastmod supersedes .Page.lastmod on the basis that .GitInfo.lastmod is more likely to be up-to-date.

However, that also seems to violate the principle of least surprise: explicit > implicit.

ryanburnette commented 3 years ago

Can you include a readme update?

coolaj86 commented 3 years ago

It's there: https://github.com/ryanburnette/eon/pull/21/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

ryanburnette commented 1 week ago

I just tested this and it does not appear to work. Is it working for you in production?