ryancarlos / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

Remove goog.userAgent.X11 constant #86

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
goog.userAgent.X11 seems a bit silly to me because the other related
constants (goog.userAgent.WINDOWS, goog.userAgent.MAC, and
goog.userAgent.LINUX) are mutually exclusive choices whereas
goog.userAgent.X11 is not.

I can only find one use of goog.userAgent.X11 in the Closure Library
in style.js:

  var buggyGeckoSubPixelPos = goog.userAgent.GECKO &&
      (goog.userAgent.MAC || goog.userAgent.X11) &&
      goog.userAgent.isVersion('1.9');

Offhand, I find it hard to believe that the usage of
goog.userAgent.X11 in there can't be changed to goog.userAgent.LINUX.
I can't imagine there is much code internal to Google that uses it
either.

Original issue reported on code.google.com by bolinf...@gmail.com on 11 Dec 2009 at 5:22

GoogleCodeExporter commented 9 years ago
This should be LINUX instead. 

Original comment by erik.arv...@gmail.com on 13 Dec 2009 at 6:18

GoogleCodeExporter commented 9 years ago
While we should probably rename userAgent.X11 to userAgent.LINUX to be 
consistent we
should keep the x11 check instead of the linux one it, unlike checking for 
linux,
will work on other unix systems.

Original comment by eae%eae.net@gtempaccount.com on 13 Dec 2009 at 10:03

GoogleCodeExporter commented 9 years ago
> it, unlike checking for linux, will work on other unix systems

Then should the name actually be goog.userAgent.NIX?

Original comment by p...@lucidchart.com on 4 Jul 2014 at 9:58