ryanchua00 / pe

0 stars 0 forks source link

View command does not handle faulty inputs #4

Open ryanchua00 opened 1 year ago

ryanchua00 commented 1 year ago

When view is entered with:

  1. no additional parameter, view
  2. non-integer parameter, view abc

No alert message is displayed.

Screenshot 2023-04-14 at 2.37.24 PM.png

I would expect a error message stating that an index is required. For example, something similar to the below delete command error message.

Screenshot 2023-04-14 at 2.37.49 PM.png

nus-se-bot commented 1 year ago

Team's Response

Severity should be medium instead since it does not affect the functionality of the view function, but lowers the user's experience of viewing contact details.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

View command has no error message on faulty inputs

When view is entered with no additional parameter, no alert message is displayed.

Screenshot 2023-04-14 at 2.24.39 PM.png

I would expect a error message stating that an index is required. For example, something similar to the below delete command error message.

Screenshot 2023-04-14 at 2.25.35 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#2182] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Confirmed, that an error message should be displayed in this scenario.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** The team acknowledges that this should be a `severity.Medium` bug. See image below. Additionally, I would like to merge issue#2 with this issue for a single `severity.Medium` bug. ![image.png](https://raw.githubusercontent.com/ryanchua00/pe/main/files/ecf79732-6f70-4dcc-b586-586c71757da5.png)