Finally repaired move counter. Add it please.

ryancramerdesign / ProcessWire-2.0

THIS IS AN OLD VERSION. Get the new one at the URL below:

https://github.com/ryancramerdesign/ProcessWire

GNU General Public License v2.0

39 stars 5 forks source link

Finally repaired move counter. Add it please. #26

Closed adamkiss closed 13 years ago

adamkiss commented 13 years ago

This was no brainer: we removed ID and we checked for the existence of said ID after that. I just moved it after the check for ID. It's just that nobody did it for a year.

More info in the commit (really, no brainer.)

adamkiss commented 13 years ago

Y NO USE MINE?

ryancramerdesign commented 13 years ago

Adam, the fix didn't work, it was throwing a javascript error:

"Uncaught ReferenceError: $from is not defined" ProcessPageList.js line 613

because that $from var needed to be defined in order for the code following it to work.

But it did help lead to the fix, which is in the latest commit. So thanks for helping to track this one down. I ended up moving the $from to the top of the function and removing it's ID attribute at the bottom of it.

adamkiss commented 13 years ago

Yeah, I realized that later :)