Open teppokoivula opened 8 years ago
Renobird
commented
8 years ago For better or worse, it was intentional for Reno Theme. I felt like the redirect when hitting enter was an unexpected and confusing behavior. Perhaps an "advanced" link that takes you to pages > search ? I don't know that the themes need to maintain identical functionality for this, but I'm open to making changes to Reno.
Renobird
commented
8 years ago I use the search in Reno daily, and it suits my needs very well. Admittedly, I haven't looked at how the default works in a while, and I have checked out Pages > Search in recent memory. I'll take a look again later today.
teppokoivula
commented
8 years ago I stumbled upon this by accident: was used to the way the default admin theme works, saw identical search in the Reno theme, so I connected the dots and expected both to function in the same way.
Admittedly there are other differences between the themes, but to me it seems more natural when it's something that the other theme doesn't have at all, as is the case with the "sliding" sidebar in Reno. When both have almost identical feature that suddenly behaves differently, in my opinion it gets confusing.
To be fair I wouldn't worry about this much unless theme choice was per site and not per user. I can very much see myself (or another user even) explaining to a client how they just have to type something in and hit return for full search.. except that it only works if they're both using the same theme, which may not be the case at all.
Additionally: like I pointed out above, I would expect the built-in themes to behave similarly, whenever possible. In my mind there's a big difference between these and any 3rd party themes one has to fetch and install separately.
Hopefully I'm making sense here :)
Renobird
commented
8 years ago I'm not opposed to them having the same behavior. I would make the case that hitting enter for the full search isn't intuitive, so perhaps a new approach to enter full search for both?
ryancramerdesign
commented
8 years ago Hmm, just tested out and see what you mean. How do you get to the full search results in the Reno theme? It looks like there isn't a way. Is there some other use case for the action of the enter key here? I find hitting enter in a search box taking me to expanded results to be a common/expected behavior, but I also don't feel that the Reno theme needs to have the same exact behavior as the default theme either. I like that there are a lot of differences between the Reno theme and default, though also understand what Teppo means about explaining to users. But there's a lot of little details like that one would have to explain to users that needed hand holding. I think the important thing is that there is at least a way to get to the full search results in the Reno theme. Maybe one of these alternatives would work in the Reno theme, while adding some consistency between themes, but still maintain the difference:
An "advanced search" link would be fine too, but would mean folks would have to re-type their search… but still better than not having a way to get there. :)
Toutouwai
commented
8 years ago I never realised you could go a full search results listing with Enter. Good to know. But something I do find odd is that hitting enter takes you to a page called called "Search" located at Admin > Pages > Search when no such page is discoverable via the menus. And it looks to me to be identical to the "Find" page. Any reason not to call the full search results page "Find"?
ryancramerdesign
commented
8 years ago It's there for a couple of reasons. One is that ProcessPageSearch (which delegates to Lister) supports translating query strings to Lister results. Whereas Lister doesn't support that on its own. In addition, if a user doesn't have "page-lister" permission, ProcessPageSearch falls back to a more lightweight search engine, the same one that it provided back before Lister existed.
On Tue, Dec 15, 2015 at 10:12 PM, Toutouwai notifications@github.com wrote:
I never realised you could go a full search results listing with Enter. Good to know. But something I do find odd is that hitting enter takes you to a page called called "Search" located at Admin > Pages > Search when no such page is discoverable via the menus. And it looks to me to be identical to the "Find" page. Any reason not to call the full search results page "Find"?
— Reply to this email directly or view it on GitHub https://github.com/ryancramerdesign/ProcessWire/issues/1543#issuecomment-164974172 .
Hitting return on the search field of the default admin theme sends me to Pages > Search, but on the Reno theme it doesn't do anything.
At first glance I thought this was just a bug in the Reno theme, but now I'm wondering if it's perhaps intentional. Either way, it would make sense for at least the native themes to function the same way in this regard, even if just to remove one unnecessary obstacle for explaining to users how to do things :)