ryancramerdesign / ProcessWire

Our repository has moved to https://github.com/processwire – please head there for the latest version.
https://processwire.com
Other
727 stars 201 forks source link

Image editing in user profile #989

Open jacmaes opened 9 years ago

jacmaes commented 9 years ago

After adding an image field in my users' profile on 2.5.20, the new crop icon appears when hovering over the thumbnail, but when I click on it, the following error appears: "Unrecognized path". Same thing when clicking on the variations icon. My guess is that these new editing tools are not supposed to appear in the user's profile.

adrianbj commented 9 years ago

Not much help I know, but just quickly wanted to note that it's working fine for me when editing a profile. What is the path it is looking for?

jacmaes commented 9 years ago

Mmmh, it works when using the default Admin theme (and logged in as a superuser), but not with Reno (in this case, I've only tried logged in as a user who's only allowed to edit his/her profile).

adrianbj commented 9 years ago

Ah I see - there are definitely issues with non superuser accounts, even with the default theme - nice spotting!

adrianbj commented 9 years ago

Ryan, while you are looking at this, do you think you might be also able to revisit the issue of the ajax html5 uploader not working when editing a user's profile. I know this was intentional for security reasons, but I think an old school uploader is just not acceptable these days - I think lots of people won't think anything has happened and won't think to save the page, or even if they do, they won't think to come back and crop/edit their pic as needed.

jacmaes commented 9 years ago

I strongly support adrian's opinion on the Ajax uploader. In fact, here's what I've seen users do in this case: as most don't understand why it takes a long time to save the page (while the pic gets uploaded), they tend to click and click again on the save button, or worse, navigate away from the page before it's actually saved. It's surprising how impatient broadband users get: they expect immediate results or assume something's wrong.

Renobird commented 9 years ago

+1 on Adrian's request. I had so many support requests from users having trouble changing their profile photo, that I created my own module that extends ProcessPageEdit. It's been working fine, and I actually forgot that it wasn't a core module.

adrianbj commented 9 years ago

Hey @Renobird - do you feel like sharing? Does it work well with the new core image editing functionality?

Renobird commented 9 years ago

@adrianbj, I don't mind at all. Let me quickly strip out some of the things that are specific to my work environment. I'll post a link to it shortly.

Renobird commented 9 years ago

https://gist.github.com/Renobird/92fb83f30ee6f151e4e0

Not sure why the indenting got weird on that gist — maybe some stray things from all the custom stuff a just removed? This exact code isn't tested. Should work with the new image stuff as it's just using ProcessPageEdit.

jacmaes commented 9 years ago

@Renobird, thanks for sharing this module. I've installed it successfully, but the core ProcessProfile still takes over whatever configuration I set in yours. What step am I missing?

jacmaes commented 9 years ago

The maximum number of files allowed does not seem to work either for the image field. I've set it to 1, and I can upload more than one.