search

ryandotsmith / l2met

Convert a formatted log stream into metrics
http://r.32k.io/l2met-introduction
GNU General Public License v3.0
284 stars 26 forks source link

Added the -receiver=true flag to the Procfile creation step in setup. #94

Closed Jwpe closed 11 years ago

Jwpe commented 11 years ago

Added the -receiver=true flag into the echo for Procfile creation in the setup script. Having this flag unset was causing the /logs endpoint to be inactive, so the l2met app created by the setup script on Heroku was unable to receive logging data from a syslog drain.

ryandotsmith commented 11 years ago

Right on! One nit-pick: you don't have to specify receiver=true. The presence of the flag is sufficient. Would you mind changing that? Ill get this merged in as soon as you do.

ryandotsmith commented 11 years ago

Also, :clap: thanks for contributing to l2met!

Jwpe commented 11 years ago

No problem! I'll happily change that. Is there a reason that -receiver doesn't need to be specifed, but -outlet is explicitly set as true? From what I could see in the config they're both defined in the same way (might be mistaken though, my Go is next-to-nonexistent).

Should those flags both just be set rather than set as true? If so I can change the outlet flag as well?

ryandotsmith commented 11 years ago

@Jwpe You are correct. There is no reason to set outlet=true. It would be great if you could correct both flags.

Jwpe commented 11 years ago

Done: both flags are just set now, rather than explicitly set to true.