ryandotsmith / nginx-buildpack

Run NGINX in front of your app server on Heroku
457 stars 248 forks source link

Race condition with Unicorn and SIGCHLD trap #1

Closed ryandotsmith closed 11 years ago

ryandotsmith commented 11 years ago

We trap SIGCHLD signals in starg-nginx so that if Unicorn, Logs, or NGINX should die, we will crash the parent process. However, there is a race condition in which Unicorn touches the app/initialization file and then immediately dies.

This is unlikely and I have not ran into the bug. However, I will leave it documented here.

ryandotsmith commented 11 years ago

This is fixed on v0.3 since we have improved process management.