search

ryandotsmith / nginx-buildpack

Run NGINX in front of your app server on Heroku
457 stars 248 forks source link

Heroku Cedar 16 throwing new error on first build. #68

Open chavenor opened 7 years ago

chavenor commented 7 years ago

Did some searching on google didn't find much. Any ideas? Is it possible that nginx upstream pgk hasn't been built for heroku-16 yet?

-----> nginx-buildpack app detected
cp: cannot stat 'bin/nginx-heroku-16': No such file or directory
 !     Push rejected, failed to compile nginx-buildpack app.
 !     Push failed
asnelzin commented 7 years ago

Current workaround for me is heroku stack:set cedar-14 -a <app_name>, but obviously it's not the right way.

moohkooh commented 7 years ago

But why it does not work on heroku-16?

asnelzin commented 7 years ago

@moohkooh because it's uses $STACK variable here: https://github.com/ryandotsmith/nginx-buildpack/blob/master/bin/compile#L7

Igor-Vuk commented 7 years ago

I am getting the same error. It would be great to update it for heroku-16 stack and also add http_gzip_static_module since I think most of us use precompressed files now.

sandeep-s commented 7 years ago

asnelzin - Thanks! Workaround works seamlessly ;-).

One question though. What if tomorrow heroku-16 stack is updated with the package? How to switch from cedar-14 to heroku-16? Thanks much in advance!

filipgolonka commented 7 years ago

@sandeep-s 

heroku stack:set heroku-16 -a <app_name>
edouardmenayde commented 6 years ago

Is there any news on this ? Can anyone explain how is it possible this repository has so much issues and pull request going on and the last commit was made 3 years ago ? Couldn't all people using this module agree to make it a kind of community plugin addon forking it ? To be clear I don't want to blame anyone here: I just don't understand what's going on...

filipgolonka commented 6 years ago

@edouardmenayde this is how open source community is working (sometimes) :) feel free to fork the repo and make a change :)

edouardmenayde commented 6 years ago

@filipgolonka Not necessarily : puppet has some amazing community modules for heavily used ones for example.

lolobosse commented 6 years ago

Hi there, looking at the Heroku PR, I found: heroku/heroku-buildpack-nginx#4 and digging a bit more into @kuwabarahiroshi work, I figured a solution which works for me: 

heroku buildpacks:add --index 1 https://github.com/kuwabarahiroshi/heroku-buildpack-nginx.git
jmejia commented 6 years ago

The Heroku fork of this repo has been updated to support Heroku-16. Similar to @lolobosse's response, you should be able to run:

heroku buildpacks:add --index 1 https://github.com/heroku/heroku-buildpack-nginx.git