search

ryandrewjohnson / react-localize-redux

Dead simple localization for your React components
https://ryandrewjohnson.github.io/react-localize-redux-docs/
MIT License
374 stars 88 forks source link

Update react peer dependency #226

Open cristianocca opened 3 years ago

cristianocca commented 3 years ago

Do you want to request a feature or report a bug? bug

What is the current behavior? Localize cannot be installed with NPM >= 7 due to peer dependency issues. Please allow react 17 in this library's peer deps.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: XXX npm ERR! Found: react@17.0.2 npm ERR! node_modules/react npm ERR! react@"17.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.0.0" from react-localize-redux@3.5.3 npm ERR! node_modules/react-localize-redux npm ERR! react-localize-redux@"3.5.3" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

What is the expected behavior? No dependency issues

Which versions of react and react-localize-redux are you using? 3.5.3

cristianoccazinsp commented 3 years ago

@ryandrewjohnson any chance for this to be updaded? Are you no longer maintaining the library?

Thanks!

ryandrewjohnson commented 3 years ago

I had been working on updating the library a while back but I just haven’t had the time unfortunately. At this point it’s not being actively maintained. There is a branch created for v4 if anyone wanted to ever try and pick it up.

cristianoccazinsp commented 2 years ago

Hi @ryandrewjohnson , looks like the library now also depends on a vulnerable package and will flag it as vulnerable (https://github.com/ryandrewjohnson/react-localize-redux/issues/235). I wonder if it would be possible to at least bump the dependencies. Are there any breaking changes or major code changes required? I may be willing to pick this up if it's just patching some packages.

cristianoccazinsp commented 2 years ago

Hello, any updates around this? Any new fork?