ryandw11 / CustomStructures

A Structure Generation plugin for Minecraft Servers.
MIT License
110 stars 36 forks source link

Log Spam on Paper server: A structure is trying to spawn without the plugin initialization step being completed. #157

Open BigScary opened 1 year ago

BigScary commented 1 year ago

Describe the bug Hey I'm running a very recent official paper 1.19.3 build. This is absolutely spamming my logs, had to uninstall the plugin for now.

A structure is trying to spawn without the plugin initialization step being completed. If you are using a fork of Spigot, this likely means that the fork does not adhere to the API standard properly.

May I humbly suggest rather than:

if(not initialized) error message

prefer:

if(not initialized) initialize

Not being a smartass. Possibly a reliable design workaround in case the boot sequence varies a little across forks or in the future of Spigot. <3 Love this plugin, my players are super excited about the possibility of our server having it (again, after some time away).

ryandw11 commented 1 year ago

This is a tricky issue since the plugin needs to have some of its initialization process after all the plugins load. Unfortunately, there is no API for me to determine this, so I have to use a somewhat hacky method (although it works well on Bukkit/Spigot).

Does the plugin ever initialize or does it stay uninitialized even after the server finishes loading? You can tell if you see

[CustomStructures] The plugin has been fully enabled with x structures.

I've never been able to reproduce this issue with an installation of paper before.

BigScary commented 1 year ago

Attaching two complete logs (together they cover a 24 hour period), please treat with care as they naturally include some player chat and whispers. <3

[Removed]

Didn't see any instance of "The plugin has been fully enabled" when I searched.

This might be relevant? Likely cause: I had the plugin disabled for many months due to performance issues. I have re-enabled it in hopes they have been since fixed, or other perf improvements on my server have given us enough headroom to absorb the burden.

[09:05:58] [Server thread/INFO]: ===============[CUSTOM STRUCTURES UPDATE]=============== [09:05:58] [Server thread/ERROR]: [CustomStructures] Unable to update plugin! Backup data is outdated! [09:05:58] [Server thread/ERROR]: [CustomStructures] Please delete the backup folder in the CustomStructures directory before continuing! [09:05:58] [Server thread/INFO]: ===============[CUSTOM STRUCTURES UPDATE]===============

ryandw11 commented 1 year ago

To fix that just delete the backup folder in the CustomStructures plugin folder.

Whitescan commented 1 year ago

This issue occures on Purpur (... Spigot -> Paper -> Pufferfish -> Purpur) build 1894 (1.19.3)

BigScary commented 1 year ago

Just confirming deleting the backup folder fixed this issue, at least for my case.

giopalma commented 1 year ago

Problem is not solved. I have this problem in Paper 1.19.3 The backup folder is not present in CustomStructures folder The plugin spams the messages

If you are using a fork of Spigot, this likely means that the fork does not adhere to the API standard properly.
A structure is trying to spawn without the plugin initialization step being completed.

But after it says

[CustomStructures] Loading structures from files.
[CustomStructures] The plugin has been fully enabled with 1 structures.