vitunes crashes and corrupts terminal

[vekin]

I used

vitunes -e init

vitunes add music/

vitunes

This results in a crash and terminal corruption in rxvt-unicode. I never get the actual interface just a line and a half of solid grey. Edit: Happens in xterm as well.

Edit: I looked at an strace and noticed it looking for mplayer and didn't see any crash. I have mplayer2 so I made a soft link to mplayer and its now working.

Edit: If I pipe away the grey output I actually see a message about mplayer.

[ryanflannery]

Hi @vekin. So it seems like you diagnosed the problem: vitunes isn't handling a missing mplayer correctly. I'll take a look at this tomorrow.

Thanks

[ryanflannery]

Confirmed the problem is simply when mplayer cannot be found in the $PATH. The ungraceful exit (leaving the terminal in an odd state) is due to calling errx() in mplayer_start() (players/mplayer.c).

[ryanflannery]

@vekin, would you mind confirming the above commit fixes the issue for you?

Thanks, -ryan

[vekin]

Sorry I wasn't getting email updates for some reason. It works as expected with no mplayer in path and gives the error without corrupting the terminal.