search

ryanflorence / react-title-component

Nested document title management for React.js
MIT License
120 stars 10 forks source link

Upgrade to support 15.5 without warnings #5

Open coryhouse opened 7 years ago

coryhouse commented 7 years ago

Tests are still throwing a propType warning:

ERROR: 'Warning: You are manually calling a React.PropTypes validation function for therenderprop onTitle.

I don't see anything off-hand. Perhaps you do?

Anyway, no warnings at runtime, tests are passing, and it's working fine in my tests.

This is to resolve #4.

rsolomon commented 7 years ago

lol I made the same pull request without checking to see if someone else did it first.

I like your's better, as it uses ES6 modules instead of the shim. I'll leave mine up for now, but will close once yours is merged (assuming @ryanflorence is still around)

MarkRabey commented 7 years ago

I just made the same one too. Oops! Doesn't look like anyone is looking at these. @ryanflorence, are you still maintaining this at all?

rsolomon commented 7 years ago

@MarkRabey I ended up switching to react-document-title. Same idea, and it's been updated to support React 15.5.x

mykyta-shulipa commented 7 years ago

@ryanflorence any chance to see this merged?

mklopets commented 7 years ago

as far as I can see, react-document-title doesn't sadly support calculating the title using the parent title 😕