ryanguai / pe

0 stars 0 forks source link

Missing destroy marker in sequence diagram #14

Open ryanguai opened 1 year ago

ryanguai commented 1 year ago

Destroy marker is provided for DeletePersonCommandParser in sequence diagram on page 9 of DG but missing for the other classes liked DeletePersonCommand

nus-pe-script commented 1 year ago

Team's Response

not really sure what is meant by that. DeletePersonCommand not found in any sequence diagram.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

[x] I disagree

Reason for disagreement: The sequence diagram is found on page 9.

Screenshot 2022-11-15 at 9.59.32 PM.png

The DeletePersonCommand should have a destroy marker once it returns a result as it is no longer needed.