search

ryanhausen / fitsmap

FitsMap: A Simple, Lightweight Tool For Displaying Interactive Astronomical Image and Catalog Data
MIT License
46 stars 9 forks source link

Adress get_cmap Deprecation #87

Closed TheSkyentist closed 3 weeks ago

TheSkyentist commented 3 weeks ago

Fixes deprecation of cm.get_cmap since matplotlib 3.7. This will no longer work in latest versions of matplotlib and should maintain compatibility with older versions.

ryanhausen commented 3 weeks ago

@TheSkyentist Thanks!

It looks like there are some CI issues.

The lint is odd because it's a file you didn't change, so I think that perhaps the formatter I use has made some changes since I last ran the CI. Would you mind running the black formatter and then committing the changes?

The OSX build issue I will take care of.

Then the CI will pass and I can merge. Thanks again!

TheSkyentist commented 3 weeks ago

Done!

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.46%. Comparing base (a7e2119) to head (23bb5fb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #87 +/- ## ========================================== - Coverage 90.73% 90.46% -0.27% ========================================== Files 5 5 Lines 745 745 ========================================== - Hits 676 674 -2 - Misses 69 71 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ryanhausen commented 3 weeks ago

Had to move osx-latest to python 3.8, will override python 3.7 action as it will never pass