fixed DictionaryKeyConverter for types of IDictionary<T,?>

ryanheath / RavenDB-NodaTime

Noda Time support for RavenDB

Other

20 stars 14 forks source link

Closed ryanheath closed 7 years ago

ryanheath commented 7 years ago

Added a fix for DictionaryKeyConverter for types of IDictionary. #4 The problem was twofold:

The code was checking for the type's interfaces, but the type itself could be an IDictionary,
We cannot instantiate an IDictionary, so we need to fallback to a concrete Dictionary.

mattjohnsonpint commented 7 years ago

Thanks! I'll merge this and include it when I publish the next version.

Could you also add a unit test please?

ryanheath commented 7 years ago

Great! The test was already written: DictionaryKeyConverterTests