As discussed (#26 ), this adds support for the DateInterval. I've basically used the Interval implementation, so this adds a bit of duplication. However, looking around in this project, I see this is how you did most of the stuff (which I can related to, this is a very simple project, not a lot of churn, so this risk of a bit of duplication is very low).
One thing, I saw that the 3rd assertion in Can_Use_NodaTime_Interval_In_Static_Index() didn't use the index, which is probably a copy-paste bug. I've boyscouted that in the new NodaDateIntervalTests, however, I've left the NodaIntervalTests.cs untouched.
ryanheath
commented
4 years ago
As discussed (#26 ), this adds support for the
DateInterval. I've basically used theIntervalimplementation, so this adds a bit of duplication. However, looking around in this project, I see this is how you did most of the stuff (which I can related to, this is a very simple project, not a lot of churn, so this risk of a bit of duplication is very low).One thing, I saw that the 3rd assertion in
Can_Use_NodaTime_Interval_In_Static_Index()didn't use the index, which is probably a copy-paste bug. I've boyscouted that in the newNodaDateIntervalTests, however, I've left theNodaIntervalTests.csuntouched.