Switch to using PackageLicenseExpression

[lahma]

• License expression is the preferred way (shows in NuGet.org and used in license validations).
• Also updated GH Actions workflow definition to use current actions, running on fast fast Ubuntu runner and publishing the NuGet packages with proper compiler flags (deterministic CI build in release mode)
• Updated to target RavenDB 5.4.1 and latest NodaTime
• Updated testing libraries

[ryanheath]

Looks great!

Give me some time to get back to you.

// Ryan

[lahma]

Great thank you, if you don't mind approving the run of GH actions workflow I could see if I broke something 😉

[lahma]

I changed this to target oldest 5.4 (LTS) RavenDB version 5.4.1 which still compiles (5.4.0 did not), so people are not required to have latest installed but can override with own more recent version package reference.

[lahma]

Thank you for merging this, now release artifacts with proper build flags are available from GH Actions artifacts: https://github.com/ryanheath/RavenDB-NodaTime/actions/runs/7905310308

[ryanheath]

Yup, I have uploaded them to nuget, might take some time before they are visible.

Thanks!

// Ryan

[lahma]

Thank you again for maintaining this project and reviewing/accepting pull requests! 👍🏻

[lahma]

For some reason I see different results from https://nuget.info/packages/RavenDB.Client.NodaTime/5.4.1

compared to opening the linked GH Actions build artifacts with NuGet Package Explorer (detects the presence of .symbols.nupkg):

EDIT: could you also please upload the symbol packages?

[ryanheath]

Hmm, nuget.org does not accept the symbol packages, because the version exists already. We could fix it with a minor version bump ...

// Ryan

[lahma]

Not a deal-breaker, just noticed them missing. Maybe with next release with more content 🙂