search

ryanheath / RavenDB-NodaTime

Noda Time support for RavenDB
Other
20 stars 14 forks source link

DictionaryKeyConverter doesn't work for IDictionary #4

Closed yurapara closed 7 years ago

yurapara commented 9 years ago

DictionaryKeyConverter CanConvert method checks if object type is derived from IDictionary that works OK for Dictionary but not for IDictionary itself.

mattjohnsonpint commented 9 years ago

I can reproduce this, but at the moment I can't figure out a solution. Will revisit.

mattjohnsonpint commented 7 years ago

FYI - this is still an issue. There is a failing unit test for it in the test suite. If anyone wants to try to fix it, a PR is welcome. Thanks.

ryanheath commented 7 years ago

14 has a fix for this issue.