serhii-k
commented
1 year ago I have squeezed the code to the bare minimum, where this bug is still reproducible.
Please see the following videos. The behaviour is the same as with the original main.dart example (or any other).
import 'dart:async';
import 'package:audio_service/audio_service.dart';
import 'package:flutter/material.dart';
late AudioHandler _audioHandler;
Future<void> main() async {
_audioHandler = await AudioService.init(
builder: () => AudioPlayerHandler(),
config: const AudioServiceConfig(
androidNotificationChannelId: 'com.ryanheise.myapp.channel.audio',
androidNotificationChannelName: 'Audio playback',
androidNotificationOngoing: true,
),
);
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Audio Service Demo',
theme: ThemeData(primarySwatch: Colors.blue),
home: Scaffold(
floatingActionButton: FloatingActionButton(
onPressed: () {
_audioHandler.play();
},
child: const Icon(Icons.play_arrow),
),
),
);
}
}
class AudioPlayerHandler extends BaseAudioHandler with SeekHandler {
static const _item = MediaItem(
id: 'mediaItem',
title: 'Test',
);
AudioPlayerHandler() {
mediaItem.add(_item);
}
@override
Future<void> play() async {
playbackState.add(playbackState.value.copyWith(
controls: [MediaControl.pause, MediaControl.stop],
processingState: AudioProcessingState.ready,
playing: true,
));
}
@override
Future<void> pause() async {
playbackState.add(playbackState.value.copyWith(
controls: [MediaControl.play, MediaControl.stop],
processingState: AudioProcessingState.ready,
playing: false,
));
}
@override
Future<void> stop() async {
playbackState.add(playbackState.value.copyWith(
controls: [],
processingState: AudioProcessingState.idle,
playing: false,
));
}
}
ryanheise
github-actions[bot]
Documented behaviour
Your audio handler must broadcast state changes so that the system notification and smart watches (etc) know what state to display. Your app's Flutter UI may also listen to these state changes so that it knows what state to display. Thus, the audio handler provides a single source of truth for your audio state to all clients.
Actual behaviour
Let's say we have MediaControl.pause, MediaControl.stop inside the notification. When a user presses the
Pauseicon theAudioHandler.pause()is called. Let's say here we're addingcontrols: [MediaControl.play, MediaControl.stop]to theplaybackStream. Unfortunately, sometimes this doesn't change the controls inside the Android notification.It can be a bug inside the plugin implementation, or it can be a bug of Android...
Minimal reproduction project
Official example: main.dart
Reproduction steps
Please, see the next message for the code.
PlayorPausestate. For example: a) the audio service is playing b) we press "Pause" inside the notification c) the audio service pauses, but the "Pause" control inside the notification doesn't change to "Play" d) thus we can't resume the playback from the notificationHowever: We can resume the playback from the app UI, or by pressing a media button of headphones.
Output of flutter doctor
Devices exhibiting the bug
This issue is easily reproducible on my Samsung Galaxy A53 5G (Android 13). It takes 3-4 pause-play changes to appear. Or sometimes it's even enough to press the "Pause" once. It looks like the icon is changing, but then returns back to "Pause".
This issue is also quite easily reproducible on the API 33 emulator. Display the notification, and press quickly over the "Play/Pause" control. After a few seconds the control gets stuck in "Pause".
As well I could reproduce in on the API 29 emulator.