ryanheise / just_audio

Audio Player
1.05k stars 672 forks source link

Improve documentation for handling removal of microphone access on iOS. #1007

Open Zurigan opened 1 year ago

Zurigan commented 1 year ago

To which pages does your suggestion apply?

Quote the sentences(s) from the documentation to be improved (if any)

To do so, edit your ios/Podfile as follows:

Describe your suggestion

Update to "To do so, edit your ios/Podfile as follows AND THEN RUN POD INSTALL" ... for anyone who might not understand that that is required in order for the edit to make a difference. Not me, other people. Yup.

ryanheise commented 1 year ago

Thanks for the suggestion.

To which pages does your suggestion apply?

* https://pub.dev/packages/audio_session#ios-setup

That link is from audio_session which has its own issues page (can you submit one there?), but it could equally apply to just_audio which requires the same instructions.

Zurigan commented 1 year ago

That link is from audio_session which has its own issues page (can you submit one there?), but it could equally apply to just_audio which requires the same instructions.

Oops, not sure how I ended up on that page ... have edited this issue, added one to the audio_session repo.

cool2apps commented 8 months ago

Is this documentation still valid?

I added following to Podfile as documentation described:

 target.build_configurations.each do |config|
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= [
        '$(inherited)',
        'AUDIO_SESSION_MICROPHONE=0'
      ]
    end

But my app still asks microphone permission. Apple may reject my app just because of this, because my app does not need microphone and I can't explain them why my app requests this permission.

Also same problem happened to android side. I used this plugin for a long time on android and it did not ask for microphone recording permission. Yesterday I uploaded an update to one of my android apps, Google Play warns that your app asks microphone recording permission, this may prevent users installing your app. I did not find any documentation how I can remove this permission from android.

ryanheise commented 8 months ago

The documentation is still valid, with the proviso that after changing the configuration file you need to clean and rebuild.

This issue is about iOS only, but if you are experiencing an issue suddenly on both iOS AND Android, you might want to look at something else you changed in your app recently.

cool2apps commented 8 months ago

The documentation is still valid, with the proviso that after changing the configuration file you need to clean and rebuild.

This issue is about iOS only, but if you are experiencing an issue suddenly on both iOS AND Android, you might want to look at something else you changed in your app recently.

You are right. Another package was using microphone. I removed that package and problem solved.