search

ryanheise / just_audio

Audio Player
1.06k stars 679 forks source link

just_audio -> media_player #341

Open nt4f04uNd opened 3 years ago

nt4f04uNd commented 3 years ago

Is your feature request related to a problem? Please describe. this a request for adding video support and becoming an official plugin

Describe the solution you'd like the plugin is quite powerful and its codebase could be adjusted to add support for video playback as well - this is how native implementations of players work. on that front, you could try and contact flutter team so perhaps you together could work on one official plugin that would combine capabilities of video_player and just_audio into a native-like player interface

Describe alternatives you've considered none

Additional context no

ryanheise commented 3 years ago

There are definitely pros and cons to this. audio_service already is fully capable of supporting video, while just_audio has an API that in theory could support video.

On the other side of the argument, there are certain things that can be done with audio that are not applicable to video, and some of this requires moving to AVAudioEngine on iOS which, as the name implies, is audio only. So we gain things by focusing only on just audio as well.

There is some potential to explore things here in a way that unifies APIs, time permitting. We can let it sit for a while and see if it gains enough interest. In the short term, there is still a lot of work to be done on the audio side (FFT, for example.)

nt4f04uNd commented 3 years ago

leaving https://github.com/flutter/flutter/issues/79079 here that might also had benefit from this