Open PhilippeVay opened 6 years ago
Thank you for your feedback!
Yeah, you're right about that, and I recognized those problems as well. I am planning on rebuilding the slider UI - as much as I'd hoped GSAP's solution would be a good fit, it's gotten too buggy and I have to admit it's time to move on to a better solution.
I also have seen the failure of the slider to automatically update, and the reason I haven't gone forward on a fix at this time is that I'm planning to change the slider's mouse interaction/animation libraries altogether.
On a side note about the keyboard functionality - this picker is one of the few that has an alternative solution for dealing with the slider issues that come out of the MacOS VoiceOver screen reader. You can fn+shift+up/down to replace the fact that the left/right behaviors fail when VoiceOver is turned on.
Thanks again for your feedback. Always appreciated.
Hey Philippe - I just rebuilt the slider around another animation library (non-GSAP). Please let me know if this fixes the problem for you so I can close out your bug. Thanks for your help! - Ryan
not work for me with Firefox 55 and Firefox 58
in branch master
, contrast-data-analytics
(with 1c885ffca4a1038f1fae25ea6b973864f7fa2945) and gh-pages
(with 8ae1f047cfbc27a2ec2bd99b7f15f2bb6f18dd39)
https://www.youtube.com/watch?v=yv6Z9o0eChw&feature=youtu.be
Thanks Philippe, the original version used a few libraries I'm going to get rid of now, which will probably alleviate the problem. I will let you know when it's ready for another review. Thanks again for the assist! - Ryan
Philippe, I think I figured out the source of the problem, although it wasn't what I originally thought. Pushed a solution that works on my version of Firefox. If you get the chance to check this, I'd appreciate it. If not, I'll give the issue 2 days before I close the ticket. Thanks again for the help! - Ryan
it works (Firefox 55 and Firefox 58): perfectly for the use of the mouse but not for the keyboard. As soon as I have a moment I add an issue. - Fabrice
Thanks, I'll pound on that shortly! - Ryan
On Thu, Nov 9, 2017 at 1:50 PM, Fabrice Gangler notifications@github.com wrote:
it works (Firefox 55 and Firefox 58): perfectly for the use of the mouse but not for the keyboard. As soon as I have a moment I add an issue. - Fabrice
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ryanhemphill/contrast-colorblind-colorpicker/issues/10#issuecomment-343253301, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5hCv4JGt8PZ3gbJr6J9rm2Y5OXk54kks5s00l6gaJpZM4QN_zV .
but not for the keyboard
I mistaked: same keyboard workflow in Firefox and Chrome
but the menu does not follow some rules: https://www.w3.org/WAI/tutorials/menus/application-menus/
Hi,
the accessibility tools options doesn't seem to work in Firefox 56.0.2 (Win 10 Pro x64). Tests in Edge 15 and Chrome 61.0.3163.100 64 bits (and newest 62.0.3202.75) were successful: dropdown appears there.
No error or warning message in the DevTools Console.
After further tests, it doesn't work when clicked but I can make it work with keyboard: first tabulation will display a large outline around icon and text (nothing happens when Enter key is pressed); second tabulation will display an outline around text alone: then pressing the Enter key will toggle the dropdown!
EDIT: Fx may not like
button > a
a link in a button