search

ryanhiebert / hirefire

A Python lib to integrate with the HireFire service -- The Heroku Proccess Manager.
https://hirefire.readthedocs.io/
Other
34 stars 21 forks source link

Fix #42 -- Aquire and dispose broker connection per request #43

Closed codingjoe closed 6 years ago

codingjoe commented 6 years ago

Acquire the connection each time quantity is called instead of only once during app loading in Django. Dispose old connection after usage.

codecov[bot] commented 6 years ago

Codecov Report

Merging #43 into master will increase coverage by 9.68%. The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   37.89%   47.58%   +9.68%     
==========================================
  Files          11       11              
  Lines         409      414       +5     
==========================================
+ Hits          155      197      +42     
+ Misses        254      217      -37
Impacted Files Coverage Δ
hirefire/procs/celery.py 80.41% <91.3%> (+34.76%) :arrow_up:
hirefire/utils.py 42.18% <0%> (+9.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0be7ea1...ba910de. Read the comment docs.

codingjoe commented 6 years ago

@ryanhiebert thanks for the quick review.