search

ryanhiebert / hirefire

A Python lib to integrate with the HireFire service -- The Heroku Proccess Manager.
https://hirefire.readthedocs.io/
Other
34 stars 21 forks source link

DjangoProcSerializer failing to call super __call__ #46

Closed kanli1984 closed 6 years ago

kanli1984 commented 6 years ago

I'm having issue with release 0.6. It's failing on line return super(DjangoProcSerializer, self).__call__(args). Based on quick research online it looks like base class ProcSerializer is old style python class and you can't call super from inherited class. The exception I'm getting is super() argument 1 must be type, not classobj. Is there way to work around this?

ryanhiebert commented 6 years ago

Thanks for the report. I think the right way to fix that is to make the ProcSerializer base class inherit from object. Would you like to make a pull request to do that?

kanli1984 commented 6 years ago

Created pull request to make ProcSerializer inherit from object. Tested locally and seem to work fine.

ryanhiebert commented 6 years ago

Merged.