search

ryanhiebert / hirefire

A Python lib to integrate with the HireFire service -- The Heroku Proccess Manager.
https://hirefire.readthedocs.io/
Other
34 stars 21 forks source link

ProcSerializer should inherit from object, otherwise super call from … #47

Closed kanli1984 closed 6 years ago

kanli1984 commented 6 years ago

…DjangoProcSerializer will fail

codecov[bot] commented 6 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   47.58%   47.58%           
=======================================
  Files          11       11           
  Lines         414      414           
=======================================
  Hits          197      197           
  Misses        217      217
Impacted Files Coverage Δ
hirefire/procs/__init__.py 64.7% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03ee76f...1f40e28. Read the comment docs.

Anton-Shutik commented 5 years ago

@ryanhiebert could you pls release this fix to pypi ?

ryanhiebert commented 5 years ago

@Anton-Shutik : done

Anton-Shutik commented 5 years ago

@ryanhiebert awesome! Thank you a lot!