Add support for default avatar when using protected photos

[colml]

When using the protected photos feature the default avatar image links are not always correct as the link is hard-coded to the old location (URL_PREFIX.'uploads/avatar/no_avatar.jpg) in most cases.

This PR updates the getAvatarPath() function and changes the hard-coded URLs to call that function instead.

[ryanhowdy]

I can't figure out why these changes are necessary. It's been a while since I wrote that code, but the Profile Destination class should handle this logic without the need for these changes.

Instead of updating the default Profile Destination class, I'd rather figure out why the Protected Profile Destination class isn't called. Which is what is supposed to happen.

[colml]

That's a good point, I hadn't looked close enough at the Protected Profile Destination class earlier. It looks like the Protected Profile Destination class is being called correctly in the getAvatarPath() function, however there are a few places where the no_avatar.jpg URL is hardcoded which bypasses the getAvatarPath() call to the Protected Profile Destination class.

Instead of the patch I submitted here is an alternative that should work:

• familyconnections/inc/Upload/Destination/Profile.php: Leave the file as is, my changes are not really needed as the Protected class will be called instead when needed.
• familyconnections/inc/Upload/Profile/Form.php: Use my patch as it fixes the hard-coded URL which bypasses the Protected class call.
• familyconnections/inc/utils.php: Instead of checking for no_avatar.jpg and returning a hard-coded URL in the getAvatarPath() function it should be passed directly to the getPhotoSource() function as other normal avatars would be processed. In other words, that function would only check for a gravatar, no checks for "no_avatar.jpg" would be made.

If you think this is a better solution and you would like me to submit a pull request for it let me know.

[ryanhowdy]

That all sounds perfect.

And yes, you can definitely submit another pull request, that would be a big help.