search

ryanhowdy / fcms

Family Connections - Create a private family website.
http://www.familycms.com
GNU General Public License v2.0
82 stars 41 forks source link

4.0.0.docker #656

Open leolivier opened 1 year ago

leolivier commented 1 year ago

Please cancel previous PR on Docker and use this one. This is exactly the same but on a clean branch on my side, not merged with french stuff.

leolivier commented 10 months ago

Hello, the checks above (codacy) does not check the commit at all, it checks some core files I didn't change at all... @ryanhowdy dy I did that PR 2 months ago, do you intend to review it?

ryanhowdy commented 9 months ago

Yea you can ignore the codacy checks, that hasn't been configured correctly yet anyway.

And sorry for the delay on reviewing this, my plan was to review it after I was done with all the other 4.0.0 code i've been working on (which is quite a lot). Currently I have 2 problems, 1) I'm busy with other code, and 2) I'm not that familiar with docker configurations right now to even decide how this should all work.

I do however appreciate the work you've done and thank you for your time. Again, sorry that I'm so slow to respond. Lots of work and little time.

leolivier commented 9 months ago

Hi, I updated the PR to remove apache and use directly php artisan serve. This results in a much lighter image (~400MB instead of ~700MB) and being based on simpler images, it does not contain any CVE (checked with Docker scout review)