ryanhugh / searchneu

Search over Classes, Professors and Employees at NEU!
https://searchneu.com
GNU Affero General Public License v3.0
74 stars 18 forks source link

Iron out some stuff with prerequisites for #32

Closed ryanhugh closed 6 years ago

ryanhugh commented 6 years ago
edward-shen commented 6 years ago

Just some more todos, from #29: Todo:

edward-shen commented 6 years ago

For your 3rd bullet, I don't think that's a good idea. I'd rather have it show up as 'None' rather than not showing up at all, because it shows that there isn't a pre/co req, rather than we have the lack of data to show it.

ryanhugh commented 6 years ago

Truuuuuueeeeee. Lets do that

edward-shen commented 6 years ago

Note: I also fixed it when a class isn't a prerequisite for anything, it properly shows None instead of an empty line.

edward-shen commented 6 years ago

First bullet kinda done, the rest of the list is in reverse order and I can't seem to fix that. I'm calling it "good enough for now".

ryanhugh commented 6 years ago

Are we pretty much done everything here? I'm working on some tests in the refactor branch and am down to hold off on tests until we get that branch in.

edward-shen commented 6 years ago

We're still missing documentation, but otherwise yeah!

edward-shen commented 6 years ago

Closing for now in favor of #15 and #35.