search

ryanhugh / searchneu

Search over Classes, Professors and Employees at NEU!
https://searchneu.com
GNU Affero General Public License v3.0
74 stars 18 forks source link

Convert CSS to Sass #40

Closed edward-shen closed 6 years ago

edward-shen commented 6 years ago

If we can use Sass, we should definitely use Sass: Our CSS is fractured across a lot of places, and Sass can help unify that.

edward-shen commented 6 years ago

Currently just converting all our CSS to Sass. Redesign will follow.

ryanhugh commented 6 years ago

What do you mean by redesign?

On Wed, Dec 13, 2017 at 5:59 PM, Edward Shen notifications@github.com wrote:

Currently just converting all our CSS to Sass. Redesign will follow.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ryanhugh/searchneu/issues/40#issuecomment-351552686, or mute the thread https://github.com/notifications/unsubscribe-auth/AFgqS0ManFnlv7on_3WE-9HJHht4h6h3ks5tAFbPgaJpZM4QrCKq .

edward-shen commented 6 years ago

Uh, so what I meant was to first convert all our files to SCSS, then utilize features of SCSS to deduplicate and cut our code down. Redesign was a bad word; "optimize" would have been better.

ryanhugh commented 6 years ago

Sounds great!

It would definitely be better to have some inheritance going in the stylesheets instead of doing this: https://github.com/ryanhugh/searchneu/blob/master/frontend/components/panels/DesktopClassPanel.js#L23