search

ryanhugh / searchneu

Search over Classes, Professors and Employees at NEU!
https://searchneu.com
GNU Affero General Public License v3.0
74 stars 18 forks source link

Formatting issues when searching #46

Closed christopher-wong closed 6 years ago

christopher-wong commented 6 years ago

When typing in the search box on first page load, the search bar gets overlaid on top of the first search result (Screenshot). Refreshing the page (or collapsing it to change the breakpoint fixes the formatting).

macOS High Sierra 10.13.2 using Safari 11.0.2

edward-shen commented 6 years ago

I have a feeling this is related to #27, and should go away once there's a rewrite (#40) of the rendering.

@ryanhugh Can you verify this? I can't seem to reproduce it in Chrome, and I don't have a mac to test it. Maybe we can make a quick fix.

ryanhugh commented 6 years ago

@christopher-wong Do you need to change the size of the browser window to make this happen?

I also don't have a mac to verify with me right now but will next week and can check then. This might be different than #27 because it looks like here the search box and the header are not moving at all, but in #27 the results are just not positioned correctly.

I also couldn't reproduce it in Chrome on Windows.

I'll look into it next week when I have access to a mac!

christopher-wong commented 6 years ago

@ryanhugh nope this happens on the first page load, without changing the window size. changing the window size actually fixes the problem.

ryanhugh commented 6 years ago

Weird! I'l take a look at it next week.

edward-shen commented 6 years ago

Just for further diagnosis, did you load directly into the site, (searchneu.com/cs3500) or did you go to the root domain, then search cs3500?

christopher-wong commented 6 years ago

Loading directly into searchneu.com/cs3500 works perfectly. Going to the root domain and typing into the search box causes the issue described above.

ryanhugh commented 6 years ago

Looks like this was due to a bug in safari not supporting transformY and calc in css together. Should be fixed in https://github.com/ryanhugh/searchneu/commit/9ea7ada365dd85f96dd9d1d6a3f0dbae86395bf6!

Just pushed the fix to prod - let me know if you still see it!