search

ryaninvents / github-issues

Issue tracking for Atom editor
MIT License
4 stars 3 forks source link

Support For Private Repos? #38

Open FlorianWendelborn opened 8 years ago

FlorianWendelborn commented 8 years ago

Would be awesome to have that, since most of the code I currently write is private. 😢

mdxprograms commented 7 years ago

I second that. Would like to see that as well.

ryaninvents commented 7 years ago

Planning on giving this package some (sorely-needed) love over the holidays; thank you both for the heads-up!

mdxprograms commented 7 years ago

Sounds great. Don't work too much over the holidays 😁

ryaninvents commented 7 years ago

@mdxprograms looks like I took your advice too literally; good news though, v0.8.0 is out and you should be able to use it with private repos once you get your key set up. Let me know if you have any issues with it.

FlorianWendelborn commented 7 years ago

@r24y How do I activate the private repo support? Preference panel only shows the README for me. Also the issues panel doesn't even open for my repo.

ryaninvents commented 7 years ago

Would you mind pasting here the version of Atom and the version of github-issues you've got installed? You should see a "User Token" field in the preferences pane, and the "GitHub Issues: Open" command should work for public repos without configuration. I'll reopen this issue while this remains unsolved.

FlorianWendelborn commented 7 years ago

https://i.imgur.com/0f70DRI.png

pjatx commented 7 years ago

I have my key setup and it's still not pulling in any issues.

image

image

Atom v1.16.0 Github-Issues 0.8.3

FlorianWendelborn commented 7 years ago

Since Atom 0.18 added GitHub integration, I revisited this package. I still have 0.8.3 installed, but now I can see the token field.

I created a token with "full private repo" access, but as far as I could tell from the network inspector this package hasn't requested the GitHub API. It just loads forever, without logging any sort of error in the console.

ryaninvents commented 7 years ago

@dodekeract the package uses the request-promise package to perform network requests, and Atom's devtools only show requests made from WebKit, so they wouldn't show up anyways.

Do you have more than one repository open in Atom? I just realized that it only displays issues for one repo at a time, and if the first repo is not a Github repo then it will not attempt to load them.

FlorianWendelborn commented 7 years ago

@r24y No, I assumed this might be an issue and closed all other projects. I also updated to quick-issues, but that doesn't fix anything. :/

ryaninvents commented 7 years ago

Hm, this is turning into a very interesting issue 🙃

Is there anything else that might be "special" about the setup? Maybe:

Any further information you can provide would be helpful, since right now there aren't enough clues as to what's happening (er, I suppose, not happening).

FlorianWendelborn commented 7 years ago

@r24y I have this issue on both my Macs. One is a 2017 MacBook Pro and the other one is a Hackintosh. It might be macOS only.

Proxy/firewall: nothing crazy, just ordinary stuff.

Permissions granted: I granted the full repo permission. It's a shame that issues isn't a separate permission...

Filter: I have it set to all.

Note: It now shows No GitHub repos found. Perhaps it's your GitHub detection? Can you verify that it works with repos cloned via e.g. git clone git@github.com:dodekeract/config?

Oh, there might be something special. All my repos are just symbolic links. However, if you're not explicitly trying to disallow them they should just work. (I clone to ~/Code/* and symlink projects to ~/.atom/projects/*) (tested the real folder, doesn't matter)

Also, my personal access token shows "never used", so this package doesn't call the API.

ryaninvents commented 7 years ago

Wonderful, this is very helpful. Thanks so much. I'll see what this turns up.