ONBUILD npm install should come after ONBUILD COPY .

ryanj / origin-s2i-nodejs

A basic Source to Image builder for OpenShift Origin, with runtime binaries from Nodejs.org

https://hub.docker.com/r/ryanj/centos7-s2i-nodejs/

Apache License 2.0

20 stars 30 forks source link

ONBUILD npm install should come after ONBUILD COPY . #15

Open rafabene opened 7 years ago

rafabene commented 7 years ago

ONBUILD npm install should come after ONBUILD COPY . Users might already have 'node_modules/' folder locally, so "npm install" could take less time to be execute if it was copied previously from the sources.

ryanj commented 7 years ago

+1 nice catch, patched!

ryanj commented 7 years ago

will push a release later today

rafabene commented 7 years ago

Thanks @ryanj ;)

ryanj commented 7 years ago

reverted the commit, reopening