search

ryanjdew / ml-slush-discovery-app

Quick up and running app for exploring MarkLogic data, based off of the marklogic-node slush template
Other
9 stars 7 forks source link

Remove hard-coding of 'discovery-app' name in modules #63

Closed patrickmcelwee closed 8 years ago

patrickmcelwee commented 8 years ago

The app name was recently hard-coded into 2 modules: here, 5 lines below that, and here.

This breaks anyone who changes the app-name, including any SEs following the cookingshow demo script, which instructs them to change the name to cookingshow. We could alternatively update that script to include more changes, or to tell them not to change the name - but this would disallow someone from installing more than one instance of this app on their server.

ryanjdew commented 8 years ago

Thanks for catching this Patrick . Just pushed an update to fix.

patrickmcelwee commented 8 years ago

wow, you're fast! ... there also seems to be an issue with the /discovery-app prefix here and here. In particular, changing the title or metadata ui-config does not have an effect on the search results.

This is because the cookingshow demo script instructs them to change that prefix to /cookingshow in ml-manage.js. Changing that line back fixed it.

I think, in this case, the demo script is wrong and they just shouldn't change that line in manage-ml.js. Agreed? If so, do you know who can change the script?

ryanjdew commented 8 years ago

Yeah. I agree that in that case it is best not to change ml-manage.js. The URI prefixes should definitely be left alone, but I think I need to refactor ml-manage.js so it doesn't rely on knowing the default database name.

ryanjdew commented 8 years ago

Alright, I think now it should be covered. I'll close this and send an email to Tom about adjusting the cooking show demo script.

patrickmcelwee commented 8 years ago

thanks!