search

ryanjdew / ml-slush-discovery-app

Quick up and running app for exploring MarkLogic data, based off of the marklogic-node slush template
Other
9 stars 7 forks source link

Reduce duplicate configurations across files #79

Open djdman2000 opened 8 years ago

djdman2000 commented 8 years ago

There are duplicate configurations across gulp.config.js, boot.js, options.js, gulpfile.js, and node-app.js. Would be good to streamline so it is easier to change ports, etc - especially when deploying to the cloud (PCF) and needing to take up environment variables.

aajacobs commented 8 years ago

I run this app on a VM, and sometimes on different ports, which means I always need to change the host and port info. I do this currently by modifying deploy/build.properties for roxy stuff, and local.json for everything else. Are you finding that insufficient?

djdman2000 commented 8 years ago

This issue concerns the deployment of Slush Discovery relative to running node boot.js. Take a look at those files, the definition of hostname/port/etc in them is unnecessary and confusing when trying to get that working.