ryanjgallagher / shifterator

Interpretable data visualizations for understanding how texts differ at the word level
Apache License 2.0
273 stars 29 forks source link

Incorrect docstring for JSDivergenceShift #5

Closed jspobst closed 4 years ago

jspobst commented 4 years ago

I just pip installed and got version 0.1.2

The JSDivergenceShift class in symmetric_shift.py has a bad doc string. It has parameters that are not accepted by the init (eg, type2score_1, type2score_2, and reference_value), and it's missing arguments that are accepted (eg, base, weight_1, weight_2, alpha)

ryanjgallagher commented 4 years ago

Thanks for catching this!