search

ryanjulian / rllab

rllab is a framework for developing and evaluating reinforcement learning algorithms, fully compatible with OpenAI Gym.
Other
1 stars 21 forks source link

Add lint checks to CI #100

Closed ryanjulian closed 6 years ago

ryanjulian commented 6 years ago

Options:

See: https://github.com/PyCQA

Important rules (running list):

CatherineSue commented 6 years ago

I find most python imports tools support alphabetical order only with import statements before from X import ... statements.

Flake8-import-order is the only tool I find that supports the alphabetical order we are using, which ignores 'from' or 'import' or 'as', like google. But flake8-import-order only prints the flake warnings instead of automatically reordering imports.

Other tools such as isort, autopep8 supports reorder, but they don't support the alphabetical order we are using. My guess is because PEP8 style only enforces groups without enforcing the order within the groups.

ryanjulian commented 6 years ago

See https://github.com/rlworkgroup/garage/issues/8