Open GoogleCodeExporter opened 8 years ago
This seems to be an issue of how the displays are arranged. The y-value is
incorrectly assigned. If I arrange the displays side by side, then it works
semi-correctly. If I arrange the displays side by side, but one a little higher
then
the other, you can still see the problem.
Original comment by dchaws
on 13 May 2010 at 1:56
Ok. So I am a programmer, but Cacoa is new to me. I checked out the code and
did a
little debugging. The problem is with the lines
_windowPosition.y = ((_screenVisiblePosition.x ==0)? _menuBarHeight:0);
in the shift left or right functions (and all others).
First, why is it _screenVisiblePosition.x, and not .y? Anyways, when my
displays are
arranged on top of one another, and when shiftit is called on a window in the
bottom
display, then _screenVisiblePosition.y is -896. So this seems to reference the
bottom
left corner of the bottom display relative to the bottom left corner of the top
display. The problem is it seems the _windowPosition.y coordinate system is
centered
in the upper left of the top display with the positive y-axis going down. So,
in my
case, _windowPosition.y should be 1080. The height of the display arranged on
top.
In my case, I hard coded this value of 1080 when _screenVisiblePosition.y is
negative.
Those of you who are Cocoa experts, and mac coordinate system experts, please
check
this problem out.
if ( _screenVisiblePosition.y >= 0 )
{
_windowPosition.y = ((_screenVisiblePosition.x ==0)? _menuBarHeight:0);
}
else {
_windowPosition.y = 1080;
}
Original comment by dchaws
on 13 May 2010 at 3:57
Hello dchaws,
I think I have fixed this.
> ((_screenVisiblePosition.x ==0)? _menuBarHeight:0);
this compensates for the Menubar height if _screenVisiblePosition.x == 0
because it
is only true for the primary monitor which starts at 0,0 and holds the menu bar
...
but still this line needed some offset improvement for multi monitor ...
Look at my patch for Issue 26 (<a
href="http://code.google.com/p/shiftit/issues/detail?id=26">link</a>
and tell me if this fixes your problem ...
Regards Marco
Original comment by masc...@gmail.com
on 17 May 2010 at 10:07
I have downloaded ShiftIt just today, and I'm having basically the same
problem, so the maybe it's still not fixed.
Original comment by a.sz.sz...@gmail.com
on 18 Jun 2011 at 6:36
Hi,
I'm the new maintainer of ShiftIt. I don't know if you have noticed, but the
development has moved to https://github.com/fikovnik/ShiftIt - please give it a
try. I believe that these issues have been fixed. If you find some other,
please submit an issue directly at github.
Filip
Original comment by krikava
on 18 Jun 2011 at 6:33
Original issue reported on code.google.com by
dchaws
on 8 May 2010 at 7:25Attachments: