ryankee / concrete

Simple continuous integration server written with NodeJS and CoffeeScript
http://ryankee.github.com/concrete
MIT License
494 stars 96 forks source link

Wrong path used for hooks #1

Closed bittersweet closed 13 years ago

bittersweet commented 13 years ago

I'm not really familiar with the path module (or node in general) but it seems the paths like git.success are not getting expanded correctly in my situation.

I have a project called metric at ~/projects/metric. When I run concrete from within ~/projects it is trying to execute metric/.git/hooks/build-worked'instead of /Users/username/projects/metric/.git/hooks/build-worked

Let me know if you require more information!

ryankee commented 13 years ago

The path was running from your current working directory. This shouldn't have caused an issue as Node was running a chdir into the directory supplied, but I've gone ahead and added full paths to everything.

Fixed by 0cbadf51e3f778ebbc1b92bda49fe24ce5ce3c71