search

ryankeleti / ega

amateur translation project of Grothendieck's EGA.
https://ryankeleti.com/ega
321 stars 34 forks source link

labels/numbering #127

Open thosgood opened 4 years ago

thosgood commented 4 years ago

a few things which i think could probably all be dealt with at the same time:

  1. [x] "labels" are doubled: e.g. — 2.8.7.1 (8.7.1).
  2. [ ] the table of contents at https://ega.fppf.site/browse doesn't seem to go any deeper than just the part level
  3. [x] it would maybe be nice to switch the part numbering to roman numerals? so that we have II.8.7.1 etc.
  4. [x] the env environment looks a bit odd in the table of contents (see image), but i'm not too sure what a better name for it would be...
  5. [x] as in the image, environments in the TOC also have their 'title', but since this is just the number again, it might be nice to surpress it? Screenshot 2020-01-26 at 21 15 47
ryankeleti commented 4 years ago

part 1 is done

ryankeleti commented 4 years ago

b0ec31d536850312f3eb956b5c720a4de0f1ab90. all labels in project now use roman.x.y.z so it looks better. I'll get around to finishing part 3

thosgood commented 4 years ago

(i don't see any changes to roman.x.y.z on the site, but maybe im just oblivious...)

ryankeleti commented 4 years ago

no, they aren't updated. the reason for this is that plastex has different attributes for the Node object, i.e. obj.ref and obj.id. The issue is that since some environments have more than one label (like equation labels), the ids don't always match up. I'm working in fixing this

ryankeleti commented 4 years ago

part 3 is now done

thosgood commented 4 years ago

awesome! how much of a faff is it to do the same for the chapter/section numbering in the navigation breadcrumbs/TOC as well? (i'm guessing that this is the same as the numbering in the references too)

ryankeleti commented 4 years ago

fixed it for references

ryankeleti commented 4 years ago

fixed it for breadcrumbs/TOC

thosgood commented 4 years ago

one last idea for part 3. (sorry!)... (also gonna edit the issue to make it clear what you've already done) the TOC (https://ega.fppf.site/browse) says Part 0, Part I, etc.