search

ryankeleti / ega

amateur translation project of Grothendieck's EGA.
https://ryankeleti.com/ega
330 stars 34 forks source link

equation references #131

Open thosgood opened 4 years ago

thosgood commented 4 years ago

it seems like the last number of references to equations is getting cut off, so that e.g. 2.8.1.1.1 and 2.8.1.1.2 both display as 2.8.1.1 Screenshot 2020-01-27 at 16 18 26

thosgood commented 4 years ago

i guess this also links back to https://github.com/ryankeleti/ega/issues/127 because the tags (8.1.1.1) don't match up with the (fixed) references (2.8.1.1.1)

ryankeleti commented 4 years ago

The issue with this is ~that plastex is mostly ignoring equation labels~ I need to handle equations, hence the labels are pointing to the enclosing environment/tag. I'll try to work on a fix/alternative

pbelmans commented 4 years ago

plasTeX deals with numbers for equations though, so I'm not sure what you mean here.

In the screenshot the equations are themselves numbered incorrectly for starters, you want to have some \numberwithin maybe? That doesn't solve incorrect \eqref below, which should refer to the (incorrectly numbered) equation (8.1.1.1) if I understand correctly.

ryankeleti commented 4 years ago

As far as I can tell, equations aren't being tagged, hence there is no way to reference them within the tag system (?)

ryankeleti commented 4 years ago

That makes more sense though, so plastex is not ignoring equations like I thought. Looking into the source I do see the equation counting, so I need to figure out how to modify the Gerby output to access those references (and make sure they're correct like you said)

ryankeleti commented 4 years ago

Also what do you mean by incorrectly labeled, EGA uses (x.y.z.n) for the n-th equation in environment (x.y.z)? I should probably automate this with \numberwithin like you say though (note, the label 2.8.1.1 refers to EGA II 8.1.1, which has been changed recently on the site to II.8.1.1).

pbelmans commented 4 years ago

In the screenshot, is the equation number (8.1.1.1) correct? It's inside 2.8.1.1 after all.

In any case, equations can also be labelled, and as such can receive a Gerby tag.

And you want plasTeX to just produce the correct equation number, which shouldn't be too hard I hope with the appropriate numberwithin and how to display counters shenanigans.

ryankeleti commented 4 years ago

Ah ok, that's great. And the equation number is correct (maybe I should call it II.8.1.1.1 to be consistent with the environment number!) As for the counters, I'll have to mess around with that

thosgood commented 4 years ago

so in my screenshot, the two links (which are now II.8.1.1 and II.8.1.1) should actually be II.8.1.1.1 and II.8.1.1.2. it looks like only the first three numbers of the label are being displayed, and so, for equations, the last one gets dropped.