ryankeleti / ega

amateur translation project of Grothendieck's EGA.
https://ryankeleti.com/ega
321 stars 34 forks source link

Finished IV.17.1 #139

Closed tholzschuh closed 4 years ago

tholzschuh commented 4 years ago

I started working on IV.17. Not sure how far I'll come, but I finished IV.17.1 and I think it's essentially ready to be merged - check again though of course.

thosgood commented 4 years ago

something that should probably be in the style/contributor guide if it isn't already is about hyperrefs: we use the command \sref{IV.1.2.3} to link to (1.2.3) in EGA IV, for example; if a reference is to a paragraph in a different EGA then we use \sref[II]{II.4.5.6} (this means you don't have to worry about manually inserting some \textbf{II} etc :-) )

thosgood commented 4 years ago

something else that would be nice if it's not a hassle (but not strictly necessary) is line breaks: i think ryan and i have opted for line breaks at the end of every sentence, just to make editing the files a bit more manageable

tholzschuh commented 4 years ago

Ah alright I see, I wasn't aware of that. I think I essentially just copied what I saw at the introduction for EGA IV... I'll try to incorporate both of your suggestions; thanks :-)

tholzschuh commented 4 years ago

Does this also apply to referencing sections/subsections? I tried \sref[0_{III}]{section:0.9} but it doesn't seem to work (and I think the beginning of EGA IV also doesn't reference like this...

tholzschuh commented 4 years ago

I think it should be done. (And contain IV.17.2 now)

tholzschuh commented 4 years ago

Ok that should be it for IV.17.3 more or less; someone still has to integrate the footnote from EGA.

thosgood commented 4 years ago

I'll have a look at this soon!

ryankeleti commented 4 years ago

Thanks for contributing! I'll add the footnote

thosgood commented 4 years ago

@tholzschuh could you possible edit the main README.md file and put your name next to the sections that you've worked on/are working on if you get a chance please? it means we can't accidentally have two people working on the same section then :-)

tholzschuh commented 4 years ago

@thosgood consider it done :)