search

ryankeleti / ega

amateur translation project of Grothendieck's EGA.
https://ryankeleti.com/ega
330 stars 34 forks source link

Finished IV.16.2 and IV.16.3 #152

Closed solov-t closed 4 years ago

solov-t commented 4 years ago
thosgood commented 4 years ago

could you please remove the little sublime text line at the top? (i have exactly the same thing, but i think it's a good idea to not merge them into master). the only other thing i can spot is that section references seem to be done manually, instead of using \sref — do you think you could possibly change these? it just then makes it a lot easier if we ever need to do something about all the references! 😇

solov-t commented 4 years ago

Thanks for the quick response! I agree that taking the line of the top of the file seems best, but is there any way to do this automatically with git? I don't wanna keep forgetting to erase it.

I do use sref though (usually)! Did I forget it somewhere?

solov-t commented 4 years ago

Ah, it was on the first paragraph. Let me change it and figure how to re-pull this.

thosgood commented 4 years ago

not sure about automatically removing that first line to be honest... but, thinking about it, do you really need it? rather than building with sublime text, there's the custom makefile in this repo, so running make ega4 is how i've been building locally

solov-t commented 4 years ago

I'm really bad at this! Haha. I'll try and see how to make "make" work on windows, but last time I've tried this all I got was a headache.

thosgood commented 4 years ago

oh, i have no idea how it all works on windows, i must admit! good luck...

thosgood commented 4 years ago

sorry to be picky, but just trying to make sure that everything is consistent in the master branch!

  1. i understand why you've defined a remarks environment, but i think it's probably better to just use remark, even when there are more than one, since this is what we've been doing so far (i think...? @ryankeleti ?)
  2. could you please add .gitignore to your local .gitignore, i.e. the master branch .gitignore doesn't need these sublime text details (this takes me back to the birth of this repo, when i had a massive nightmare trying to sort out not committing my local .gitignore, so you have my sympathy)
solov-t commented 4 years ago

That's okay, consistency is important.

  1. I've actually searched this one and turns out there are no "remarques" in EGA0-1 and EGAI. Since they also changed their notation to "remarques" I've considered the change relevant (but of course, if you guys don't think so, there's no problem in not using it). Also it is used more than a couple of times on section IV.16 alone.
  2. This makes sense. I'll figure how to do this and fix this in a second.
thosgood commented 4 years ago

just gone back and realised that i used remark instead of remarks for EGA.II, so if we merge yours then i'll just note down somewhere that i need to go and fix this! but it's really not a very time consuming thing, so i have zero preference. @ryankeleti can have the deciding vote here ;-)

ryankeleti commented 4 years ago

I don't have a preference either (or the deciding vote!), go ahead. as for \srefs, I plan on moving sections to \sref as well. There is really no reason to use \label{(sub)section:*} as we have been, so I'll probably fix that soon