ryankurte / efm32-base

Base project for Silicon Labs EFM32 microcontrollers
89 stars 33 forks source link

EFM32GG11B/EFM32GG12B wrong architecture detected #17

Open quirxmode opened 4 years ago

quirxmode commented 4 years ago

The architecture of the new GG11/GG12 is Cortex M4 but falls through to M3 in toolchain/efm32-base.cmake.

ryankurte commented 4 years ago

hey thanks for the issue! looks like we're missing the GG families here.

if you'd like to add them, a PR would be great, otherwise i'll add it to the list ^_^

quirxmode commented 4 years ago

Np you can add them if it's fine with you. :)

linted commented 4 years ago

I realize this is a really old ticket, but since it is still open, I'll jump in. the BGM113A256V2 is a cortex-m4 but falls under BGM1 which has some cortex-m3's in it. What would be the best way of handling something like this?

ryankurte commented 4 years ago

ahh what an exercise in edge case discovery ^_^ i think probably another if statement here matching the family with a nested if to override weird devices / fall through to whatever is most common?