search

ryankurte / embedded-hal-compat

Rust embedded-hal inter-version compatibility layer
MIT License
15 stars 11 forks source link

Update to embedded-hal 1.0.0 #34

Closed ryankurte closed 7 months ago

ryankurte commented 7 months ago

updates #32

cc. @dirbaio @MabezDev

ryankurte commented 7 months ago

hmm looks like DelayUs has caused us some MSRV problems with 1.62 related to https://github.com/rust-lang/rust/issues/88581 ...

not sure why we're seeing this here but not in embedded-hal which has an MSRV of 1.60 though.

onkoe commented 7 months ago

I was getting that MSRV error when building before d706ecd. It seems to be fixed now!

Have you checked if these tests are still failing? This crate would be super handy for me. :D

edit: Ah, my apologies. Using cargo +1.69.0 build --target=x86_64-unknown-linux-gnu results in the failures denoted in the tests.

(unrelated, but I really love sparse and don't know how we lived without it :sob:)

onkoe commented 7 months ago

Also, another crate hit this problem and ended up implementing their own div_ceil as a utility method. As a quick and dirty solution to allow folks to use 1.69, it might work..? https://github.com/sarah-ek/faer-rs/blob/main/src/utils/mod.rs

eldruin commented 7 months ago

We might also raise the MSRV to 1.73.0 (~ 6 months old) which is when div_ceil was stabilized. It might be a bit too new for a compatibility layer, but it is better than nothing. If someone really needs an older version, they can always submit a PR.

ryankurte commented 7 months ago

We might also raise the MSRV to 1.73.0

good call, let's do that and get something out / worry about prior versions if it turns out to be a problem ^_^

eldruin commented 7 months ago

Is there anything missing or can we go ahead with a release?