CI breaks for pull requests (No API token)

ryankurte / go-mapbox

Golang Mapbox API module

MIT License

38 stars 20 forks source link

CI breaks for pull requests (No API token) #10

Closed ryankurte closed 5 years ago

ryankurte commented 7 years ago

Pull requests don't get loaded with an API token, so all tests fail against PRs (see #9).

Current solution is to create a local branch for the pull request which then tests run against, but it's a bit frustrating for contributors not to be able to test the PR.

@aravind741 could you please try adding your own mapbox API keys to your fork as an environmental variable through the travis settings (rather than the .travis.yml)? Settings URL should be something like https://travis-ci.org/aravind741/go-mapbox/settings

If that sorts out the PR test problem I will add it to the readme.

ryankurte commented 7 years ago

Otherwise the option is for a contributor / admin to run:

git checkout -b USER-PR master
git pull git://github.com/USER/go-mapbox.git PR
git push origin USER-PR

Which updates the push build in the github PR view, but not the PR build. Then you have to admin override the PR (with one test passing) to merge it :-/

thearavind commented 7 years ago

@ryankurte Adding the token to my travis account is not solving the problem

I have closed the PR and reopened it again to re run the tests

ryankurte commented 7 years ago

Thanks for trying it out! Will have to inquire with travis-ci how to resolve this.

PR #9 manually merged for now, and will have to continue with that till there's a better solution.

ryankurte commented 5 years ago

closing for inactivity, will worry about this again if it's a regular problem