search

ryanlecompte / redis_failover

redis_failover is a ZooKeeper-based automatic master/slave failover solution for Ruby.
http://github.com/ryanlecompte/redis_failover
MIT License
539 stars 65 forks source link

Insert the "root_znode" path before "master_redis_node_manager_lock" and expose via accessor #52

Closed jzaleski closed 11 years ago

jzaleski commented 11 years ago

We were having issues while attempting to use the node-manager across two clusters. The first cluster would start up, properly pick master and correctly handle failover however for the second cluster a master would never be promoted and though failover seemed to work the cluster status was not being properly tracked by node-manager.

This fix has been applied to our staging environment and appears to be doing the right thing (now). In attempting to test this I found that there was going to be a lot involved and wanted to get feedback on what would make sense to test, at this point, if anything.

ryanlecompte commented 11 years ago

This looks great! Thanks for the fix.

jzaleski commented 11 years ago

Glad to help.

wr0ngway commented 11 years ago

+1 any chance of a gem release for this?

ryanlecompte commented 11 years ago

Definitely. I recently started a new job and have been quite busy lately, but I'll try to get a release out tonight or tomorrow. Thanks!

On Fri, Feb 15, 2013 at 7:18 AM, Matt Conway notifications@github.comwrote:

+1 any chance of a gem release for this?

— Reply to this email directly or view it on GitHubhttps://github.com/ryanlecompte/redis_failover/pull/52#issuecomment-13611048.

jzaleski commented 11 years ago

Thanks!

On Fri, Feb 15, 2013 at 10:23 AM, Ryan LeCompte notifications@github.comwrote:

Definitely. I recently started a new job and have been quite busy lately, but I'll try to get a release out tonight or tomorrow. Thanks!

On Fri, Feb 15, 2013 at 7:18 AM, Matt Conway notifications@github.comwrote:

+1 any chance of a gem release for this?

— Reply to this email directly or view it on GitHub< https://github.com/ryanlecompte/redis_failover/pull/52#issuecomment-13611048>.

— Reply to this email directly or view it on GitHubhttps://github.com/ryanlecompte/redis_failover/pull/52#issuecomment-13611289.

ryanlecompte commented 11 years ago

Just released redis_failover 1.0.2 with these changes. Thanks!

jzaleski commented 11 years ago

Thanks again!

On Sunday, February 17, 2013, Ryan LeCompte wrote:

Just released redis_failover 1.0.2 with these changes. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/ryanlecompte/redis_failover/pull/52#issuecomment-13689300.