search

ryanlovett / nbnovnc

Jupyter notebook extension for proxing a VNC session
26 stars 17 forks source link

adapt code to jupyterlab #11

Closed djangoliv closed 5 years ago

djangoliv commented 5 years ago

thanks for your work. Here what I did to adapt the project to jupyterlab.

ryanlovett commented 5 years ago

Thanks @djangoliv! I'm surprised nbnovnc works at all but I'm happy to integrate your changes. I'll leave just a couple of comments...

djangoliv commented 5 years ago

Thanks for your review @ryanlovett

djangoliv commented 5 years ago

I updated my PR with your remarks Thanks

ryanlovett commented 5 years ago

Thanks!