ryanlovett / nbnovnc

Jupyter notebook extension for proxing a VNC session
26 stars 17 forks source link

add overrides for Xtightvnc invocation #7

Open mbmilligan opened 6 years ago

mbmilligan commented 6 years ago

So I've just gotten this working on a CentOS system. For reasons beyond my understanding, Debian derivatives ship with TightVNC, but RedHat derivatives use TigerVNC. This results in different executable naming (/usr/bin/Xvnc vs /usr/bin/Xtightvnc) and different defaults. In particular, TigerVNC defaults to security settings that wind up requiring the user to input a (not existing) password.

In my CentOS container I got around this by creating a /usr/bin/Xtightvnc shell script like:

#!/bin/sh
exec /usr/bin/Xvnc $@ -localhost -SecurityTypes=None

But it would be nicer to be able to either configure the command that supervisor runs, or at least drop a script like that in a less-hardcoded location.

ryanlovett commented 6 years ago

Does 5a64d9e suffice? You could set it to be your wrapper script or to the expanded command that is run from it.

mbmilligan commented 6 years ago

That definitely ought to do the trick. I'll let you know once I've had a chance to test it, but I expect that'll work.