search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

It doesnt live reload on icov update when 2 panes #109

Closed outluch closed 6 years ago

outluch commented 6 years ago

I have 2 panes. One for index.js, second for tests.js. I started supervisor to run my test-coverage command and regenerate lcov on every change in my sources. What I expect is updating green/red marks in index.js. What I see is it doesnt update until I turn off and on again Watch mode. Or until I switch to other tab (even Settings) and back to index.js.

ryanluker commented 6 years ago

@outluch thanks for the issue, I think i have seen this issue as well when you have more then one pane (but not a multi root workspace). can you confirm that the live reload occurs when you change the index.js file in a single pane view?

outluch commented 6 years ago

Look, I don't think it depends on panes at all. I tried to open my index.js, turn on watch and modify my lcov.info via command line nano. It didn't react to changes. Actually watch works only on tab change event. So I can create new dummy file just to switch tab to it, then close it without save and my coverage updates (if there changes in lcov) FYI: I am on OSX 10.13.1. How do you watch lcov changes? There are chokidar in node js for that kind of watching. I think it can be osx-related issue, because of mac file system caching or something, i dont know exactly.

ryanluker commented 6 years ago

@outluch thanks for the extra info, i will take a look at this with the 1.3.1 release I am working on. I use vscodes file watching api's to efficiently watch files for changes. I am thinking the api might have been updated for it in the 1.18.1 release which is causing the watching oddities.

ryanluker commented 6 years ago

@outluch I updated vscode to latest 1.19.x and wasnt able to reproduce on my ubuntu 17.10 install, I will attempt to get someone to test on their macosx. worst cause I will retest these features in the 1.4.0 upcoming release.

ryanluker commented 6 years ago

moving this work to the 1.4.0 re-architecture release